vlw/scaffold
1
0
Fork 0
Code Issues 2 Pull requests 2 Projects Releases 28 Packages Wiki Activity Actions

Set Database env credentials without returning a new instance #24

Merged
vlw merged 1 commit from refs/pull/24/head into master 2026-02-11 17:39:03 +01:00
Conversation 0 Commits 1 Files changed 1 +2 -4
vlw commented 2026-02-11 17:38:35 +01:00 (Migrated from codeberg.org)
Copy link

This is a follow-up PR from #22. Instead of returning a new instance after setting the environment variables we simply do nothing. Most of the extending classes will not take advantage of the new instance anyways, and will just call new Database() as before. Of course, as mentioned in #22 this setup is not ideal, and another solution should be implemented to instance this class.

This is a follow-up PR from #22. Instead of returning a new instance after setting the environment variables we simply do nothing. Most of the extending classes will not take advantage of the new instance anyways, and will just call `new Database()` as before. Of course, as mentioned in #22 this setup is not ideal, and another solution should be implemented to instance this class.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug
Something is not working

  
dependency
Related to an upstream repository, already reported there

  
documentation

   
feature
New feature

  
invalid
Something is wrong

  
refactor
Change of something existing

No labels
bug
dependency
documentation
feature
invalid
refactor
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
vlw/scaffold!24
No description provided.