vlw/scaffold
1
0
Fork 0
mirror of https://codeberg.org/vlw/scaffold.git synced 2026-02-26 03:21:57 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: set Database env credentials without returning a new instance (#24)

Browse source 
This is a follow-up PR from #22. Instead of returning a new instance after setting the environment variables we simply do nothing. Most of the extending classes will not take advantage of the new instance anyways, and will just call `new Database()` as before. Of course, as mentioned in #22 this setup is not ideal, and another solution should be implemented to instance this class.

Reviewed-on: https://codeberg.org/vlw/scaffold/pulls/24
This commit is contained in:
Victor Westerlund 2026-02-11 17:39:01 +01:00
parent 1536079fe3
commit 3b8fadf613
1 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/Database/Database.php
View file

@ -26,9 +26,9 @@
* @param string $username
* @param string $password
* @param string $database
* @return static
* @return void
*/
public static function from_credentials(
public static function set_credentials(
?string $host = self::DEFAULT_HOSTNAME,
?string $username = self::DEFAULT_USERNAME,
?string $password = self::DEFAULT_PASSWORD,
@ -44,8 +44,6 @@
$_ENV["mariadb"]["user"] = $username;
$_ENV["mariadb"]["pass"] = $password;
$_ENV["mariadb"]["db"] = $database;
return new static();
}
/**