PIP not working with other languages #4

Closed

opened 2022-06-16 14:33:57 +02:00 by Ghost · 0 comments

Ghost commented

2022-06-16 14:33:57 +02:00

(Migrated from codeberg.org)

Disney+ has been released in lots of countries in the past month. I live in hungary and if I try to use this extension then it doesn't show up the button. I looked into the code and probably have found the problem. It's with the url. In other languages the url of a video looks like this: disneyplus.com/language-code/video/etc... . In your code it slices up the the url by the /-es and checks if the arrays number 1 element is equals to video, but here, it's the language code, so it never will be true. So what I think you should do is add another check in the code if the arrays element number 2 equals to video, and then it probably will work.

Thanks,
Vince

Disney+ has been released in lots of countries in the past month. I live in hungary and if I try to use this extension then it doesn't show up the button. I looked into the code and probably have found the problem. It's with the url. In other languages the url of a video looks like this: **disneyplus.com/_language-code_/video/_etc..._** . In your code it slices up the the url by the /-es and checks if the arrays number 1 element is equals to _video_, but here, it's the language code, so it never will be true. So what **I** think you should do is add another check in the code if the arrays element number 2 equals to _video_, and then it probably will work. Thanks, Vince

Commenting is not possible because the repository is archived.